Skip to content

Rollup of 7 pull requests #103026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Oct 14, 2022
Merged

Rollup of 7 pull requests #103026

merged 19 commits into from
Oct 14, 2022

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

WaffleLapkin and others added 19 commits October 13, 2022 07:33
@WaffleLapkin
rustdoc: don't ICE on TyKind::Typeof
3df9afc
@wesleywiser
Add suggestion to the "missing native library" error
097b6d3 
If we fail to locate a native library that we are linking with, it could
be the case the user entered a complete file name like `foo.lib` or
`libfoo.a` when we expect them to simply provide `foo`.

In this situation, we now detect that case and suggest the user only
provide the library name itself.
@GuillaumeGomez
Update browser-ui-test version to 0.12.3
c47337e
@GuillaumeGomez
Improve code for unsafe-fn rustdoc GUI test
16cfd6c
@WaffleLapkin
Add test for issue 102986
577d2cf
@Noratrieb
Add new bootstrap entrypoints to triagebot
6d609c5
@nbdd0121
Ensure enum cast moves
de0396c
@aliemjay
replace ReErased with fresh region vars in opaque types
d2d3d94
@nbdd0121
Add test for issue 102389
f1452fc
@nbdd0121
Bless tests
247da7b
@nbdd0121
Fix test
4a25a49
@GuillaumeGomez
Add links to relevant pages to find constraint information
2214748
@matthiaskrgr
Rollup merge of rust-lang#103000 - wesleywiser:suggest_libname, r=com…
c7f048e 
…piler-errors

Add suggestion to the "missing native library" error

If we fail to locate a native library that we are linking with, it could be the case the user entered a complete file name like `foo.lib` or `libfoo.a` when we expect them to simply provide `foo`.

In this situation, we now detect that case and suggest the user only provide the library name itself.
@matthiaskrgr
Rollup merge of rust-lang#103006 - WaffleLapkin:rustdoc_dont, r=compi…
9692d98 
…ler-errors

rustdoc: don't ICE on `TyKind::Typeof`

Fixes rust-lang#102986

I'm not sure why rustdoc started seeing `TyKind::Typeof` all of a sudden (the code being editted was last touched 3 months ago), probably something to do with error recovery? idk.
@matthiaskrgr
Rollup merge of rust-lang#103008 - aliemjay:opaque-parent-substs, r=o…
059bbf7 
…li-obk

replace ReErased with fresh region vars in opaque types

See inline comments.

Prior art rust-lang#102943. cc ``@compiler-errors`` ``@oli-obk``

Fixes rust-lang#100267
Fixes rust-lang#101940
Fixes rust-lang#102649
Fixes rust-lang#102510
@matthiaskrgr
Rollup merge of rust-lang#103011 - GuillaumeGomez:improve-unsafe-fn-g…
5f156cc 
…ui-test, r=notriddle

Improve rustdoc `unsafe-fn` GUI test

r? ``@notriddle``
@matthiaskrgr
Rollup merge of rust-lang#103013 - Nilstrieb:patch-1, r=jyn514
ea709c2 
Add new bootstrap entrypoints to triagebot

They haven't been added yet, as seen in rust-lang#103007.

r? ``@jyn514``
@matthiaskrgr
Rollup merge of rust-lang#103016 - nbdd0121:enum, r=pnkfelix
cf67565 
Ensure enum cast moves

Fix rust-lang#102389

r? ``@pnkfelix``
@matthiaskrgr
Rollup merge of rust-lang#103021 - GuillaumeGomez:constraint-pages, r…
3f12e4b 
…=Amanieu

Add links to relevant pages to find constraint information

I think it can be quite helpful to find this information more quickly.

r? `@Amanieu`
@rustbot rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Oct 13, 2022
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=7

@bors
Copy link
Collaborator

bors commented Oct 13, 2022

📌 Commit 3f12e4b has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 13, 2022
@bors
Copy link
Collaborator

bors commented Oct 14, 2022

⌛ Testing commit 3f12e4b with merge edabf59...

@bors
Copy link
Collaborator

bors commented Oct 14, 2022

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing edabf59 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 14, 2022
@bors bors merged commit edabf59 into rust-lang:master Oct 14, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 14, 2022
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Perf Build Sha
#103021 9b2c4c706cec202ddd4af065e0c8ea69f53d8755
#103016 0801f9466e95d79e0e2678452d481b0148f7b2ea
#103013 65b5cd3d0b3febc0df6c4c6524b7e2f09b313d79
#103011 3fcb51b6ced4c2c214660bf980c3579964e6fb46
#103008 559191e796e7248f80dda3a4a320eab683185c12
#103006 ea1fcc0bf6ba5e0f798b08c194f1e6c116cc5734
#103000 88f0bc82d2d3658e4710e7c4915cc6c802c3e24f

previous master: 60bd3f9677

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (edabf59): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 0.9% [0.7%, 1.1%] 6
Regressions ❌
(secondary)		 0.4% [0.4%, 0.4%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.5% [-1.5%, -0.3%] 7
All ❌✅ (primary) 0.9% [0.7%, 1.1%] 6

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 1.4% [0.7%, 2.1%] 2
Regressions ❌
(secondary)		 2.3% [2.3%, 2.3%] 1
Improvements ✅
(primary)		 -3.0% [-3.2%, -2.7%] 3
Improvements ✅
(secondary)		 -2.4% [-2.8%, -1.1%] 13
All ❌✅ (primary) -1.2% [-3.2%, 2.1%] 5

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean1 range count2
Regressions ❌
(primary)		 2.5% [1.3%, 3.7%] 2
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -2.8% [-2.8%, -2.8%] 1
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.7% [-2.8%, 3.7%] 3

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2 ↩3

  2. number of relevant changes ↩ ↩2 ↩3

@rustbot rustbot added the perf-regression Performance regression. label Oct 14, 2022
@nnethercote
Copy link
Contributor

diesel has been noisy lately.

@rustbot label: +perf-regression-triaged

@rustbot rustbot added the perf-regression-triaged The performance regression has been triaged. label Oct 16, 2022
@matthiaskrgr matthiaskrgr deleted the rollup-gfmlfkt branch December 22, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic merged-by-bors This PR was explicitly merged by bors. perf-regression Performance regression. perf-regression-triaged The performance regression has been triaged. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.